-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code organized into more elegant structure. #145
base: master
Are you sure you want to change the base?
Conversation
The tooltip exceptions were fixed in PR #137 I like the file splitting, keeps the alphabetical issue out of the way |
Im sorry i take that back they didn't make it into the commit |
If it looks scary to you, I can explain :-) |
Hey Oleg, Thanks much for the PR! It does look scary, and I think we should hold off splitting files until we remove redundancy in codebase. It will be easier that way. I like to organization of codebase, and this is definitely a way I would want to follow, but not immediately. Meanwhile there are actually some changes going in parallel, you can check them in other branch here |
It is very difficult to manage changes and/or merges with one single file. The redundancy handling will be much easier in smaller files. After the split, we can finally use angular.extends etc. for copy/past code. I will do additional refactoring to reduce redundancy, but it can be made only after split :-( |
Project changed to support multiple src files.
Important: templates & *.mdl.js - must be included first, the rest *.js files may be included in any order after it.
js files naming:
*.mdl.js - modules description
*.dir.js - directives
*.srv.js - services (factories etc)
*.ctrl.js - contollers
For now I only moved the code to separate files. There is more refactory needed to reuse some parts of the components.