Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code organized into more elegant structure. #145

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Code organized into more elegant structure. #145

wants to merge 8 commits into from

Conversation

Oleg-Imanilov
Copy link

Project changed to support multiple src files.

Important: templates & *.mdl.js - must be included first, the rest *.js files may be included in any order after it.

js files naming:

*.mdl.js - modules description
*.dir.js - directives
*.srv.js - services (factories etc)
*.ctrl.js - contollers

For now I only moved the code to separate files. There is more refactory needed to reuse some parts of the components.

@chaosfinity
Copy link

The tooltip exceptions were fixed in PR #137

I like the file splitting, keeps the alphabetical issue out of the way

@chaosfinity
Copy link

Im sorry i take that back they didn't make it into the commit

@Oleg-Imanilov Oleg-Imanilov changed the title Preparation for big split. Code organized into more elegant structure. Sep 23, 2014
@Oleg-Imanilov
Copy link
Author

If it looks scary to you, I can explain :-)
But after splitting it will be much easier to develop & marge.

@chinmaymk
Copy link
Owner

Hey Oleg, Thanks much for the PR!

It does look scary, and I think we should hold off splitting files until we remove redundancy in codebase. It will be easier that way. I like to organization of codebase, and this is definitely a way I would want to follow, but not immediately. Meanwhile there are actually some changes going in parallel, you can check them in other branch here

@Oleg-Imanilov
Copy link
Author

It is very difficult to manage changes and/or merges with one single file. The redundancy handling will be much easier in smaller files. After the split, we can finally use angular.extends etc. for copy/past code.
Alternative is to merge my change with PR branch, but it will be almost impossible to merge it with master after few changes. Believe me, as earlier the split will be merged - the project will be more stable and the fixes can be isolated.

I will do additional refactoring to reduce redundancy, but it can be made only after split :-(
Please, think again. As I said , there no changes in logic - only code move!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants