Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/votes #271

Closed
wants to merge 40 commits into from
Closed

Fix/votes #271

wants to merge 40 commits into from

Conversation

Dan-Y-Ko
Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko commented Oct 1, 2024

Description

I've spent a good amount of time on this now, so I have a bit better understanding of what the issue is, but still don't know how to actually fix this. It is related to the caching. I have no idea why increasing timer works as a temporary solution, it doesn't really make any sense to me. I've tried to figure out what causes the caching to mess up when clicking rapidly but I couldn't track it down and I couldn't find anything about this issue. This is the best we've got for now

Increasing the timer to 2 seconds temporarily fixes this issue but it's most likely not the correct solution

Issue link

Fixes #192

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 9:26pm

@Dan-Y-Ko Dan-Y-Ko closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with clicking on add/remove vote and clicking it again immediately
1 participant