Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(package.json): use make #605

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ci(package.json): use make #605

wants to merge 1 commit into from

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented May 13, 2021

Description

Use make in npm scripts

Motivation and Context

  • Simplify npm scripts with make (using make dependencies, instead of linking different npm pre scripts)
  • make install: only runs yarn install when yarn.lock is changed
  • make build: only runs yarn tsc when .ts files are changed
  • npm prepack: use this npm stage to make production build

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

coveralls commented May 13, 2021

Coverage Status

Coverage remained the same at 98.86% when pulling 22e9f05 on make into a569122 on master.

@chimurai chimurai force-pushed the make branch 2 times, most recently from 240bbf0 to fdc2c14 Compare May 19, 2021 19:04
@ghost
Copy link

ghost commented May 19, 2021

Congratulations 🎉. DeepCode analyzed your code in 3.629 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

@chimurai chimurai marked this pull request as draft March 22, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants