Develop the Explore page #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo: * tests
summary of explore page requirements: * all filters optional, including search query * control over result ordering * page size of 20ish results? * ideally reuse the "cards grouped together / cards grouped by source" UI from grid selector
todo: * sorting by source doesn't work. probably just disable source reordering * remove search filter for settings applying to cardbacks or not * move search filters into left-hand pane, put results on right-hand pane * multi-select for card types to include in results
bcherny/json-schema-to-typescript#258 considering moving from `json-schema-to-typescript` because of this issue - probably a good opportunity to modernise our frontend/backend type checking stack.
* define all shared types and request/response payload types in json schemas, then build language-native interfaces for those types with quicktype * eliminates the need to read json schemas at runtime in backend and in frontend * standardise to camelCase across the board for transport types * this is an API breaking change
* remove redundant references to `common` folder * update frontend with multi-stage build to reduce image size * limit elasticsearch memory usage in local development * refer to base docker-compose file in "prod" compose file directly (so you don't need to remember to include it when running compose)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New page for browsing image database w/o needing to build a project in the project editor:
Screencast from 2025-02-09 22-59-11.webm
Added a form for adding cards to project through detailed view modal:
Reworked shared frontend/backend typing:
quicktypequicktypein backend tooquicktypeandpydantic's validation methodsChecklist
pre-commitand installed the hooks withpre-commit installbefore creating any commits.