Feature: Adding support for single threshold non-wear detection across watch platforms #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test of different non wear detection methods
Making std only the default by setting range_criteria = None, if not None, then we use it
Test of different non wear detection methods
Making std only the default by setting range_criteria = None, if not None, then we use it
…/childmindresearch/wristpy into feat/issue-99/non-wear-detetion-single-threshold
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 96.34% 96.66% +0.31%
==========================================
Files 11 11
Lines 575 569 -6
==========================================
- Hits 554 550 -4
+ Misses 21 19 -2 ☔ View full report in Codecov by Sentry. |
Adds the range_criteria as a user-defined setting for non-wear detection
Adding tests with user-defined range criteria in config
|
Probably good for a review but might be best to finalize it after the orchestrator is merged? Or maybe just get some feedback on using config.Settings to pass Optional |
Fix merge conflicts
frey-perez
reviewed
Sep 24, 2024
Moving to single feature non-wear detection for all watches by only using std of acceleration Fixing smoke test as per Freymon's PR comments
Fix docstrings for single criteria
Removing outdated RANGE_CRITERIA
Ruff fix for unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #99
Re-based to #71 , this PR modifies the
detect_nonwearfunction to default to using a single thresholdstd_criteria. This allows the non-wear detection algorithm to work with both .gt3x and .bin files without the need of chaning therange_criteria