Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save files downloaded from s3 #130

Open
wants to merge 9 commits into
base: github-action
Choose a base branch
from
Open

Save files downloaded from s3 #130

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f4b9660
Save files downloaded from s3
KyleDolezal Feb 11, 2024
ff6b15a
Download ridership data from s3 and commit to repo
dcjohnson24 Feb 13, 2024
8f68120
Change branch
dcjohnson24 Feb 13, 2024
e12eb94
Add updated ridership data that was downloaded from s3
Feb 13, 2024
17cc0a6
Remove 'on push' and change branch to main
dcjohnson24 Feb 13, 2024
dc09577
Merge branch 'save-ridership-file' of github.com:chihacknight/ghost-b…
dcjohnson24 Feb 13, 2024
32696cd
Update checkout github action
KyleDolezal Feb 25, 2024
c0f3a1f
Save downloaded data on main branch
KyleDolezal Feb 25, 2024
631abdf
Merge pull request #131 from chihacknight/save-ridership-file
dcjohnson24 Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/download-data.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,11 @@ jobs:
- name: download schedule vs realtime
uses: ./.github/actions/download-from-s3
with:
file-path: schedule_vs_realtime_all_day_types_routes.json
file-path: schedule_vs_realtime_all_day_types_routes.json
- uses: oleksiyrudenko/gha-git-credentials@v2-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this generates a warning about updating to Node 20. I don't know if there is a later version for this action, but maybe line 15 could be changed to actions/checkout@v4?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcjohnson24 I have upgraded checkout to version 4, but I am still getting a warning for gha-git-credentials. Unfortunately, there is not a newer version of this action. I can make a PR to that repo, but in the meantime I suggest living with the warning in our repo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcjohnson24 I made a PR in the github action to upgrade to version 20 here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this and submitting the PR. I agree that we can live with the warning.

with:
token: '${{ secrets.GITHUB_TOKEN }}'
- run: |
git add .
git commit -m 'Add updated route data that was downloaded from s3'
git push origin save_downloaded_files
dcjohnson24 marked this conversation as resolved.
Show resolved Hide resolved