Use full s3 URL for ConnectionTimeoutError #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcjohnson24
changed the title
dcjohnson24
assigned dcjohnson24 and lauriemerrell and unassigned dcjohnson24 and lauriemerrell
KyleDolezal
reviewed
Nov 23, 2023
utils/s3_csv_reader.py
Outdated
| try: | ||
| df = pd.read_csv(filename.as_uri(), low_memory=False) | ||
| except (botocore.exceptions.ConnectTimeoutError, botocore.exceptions.EndpointConnectionError): | ||
| s3_filename = '/'.join(filename.parts[-2:]) |
There was a problem hiding this comment.
@dcjohnson24 This may be a dumb question, but why don't we try the f'https://{csrt.BUCKET_PUBLIC}.s3.us-east-2.amazonaws.com/{s3_... approach the first time around if the pd.read_csv(filename.as_uri(), low_memory=False) may throw an error?
There was a problem hiding this comment.
Thanks for catching this. You're right that it would probably work to just use the f'https://{csrt.BUCKET_PUBLIC}.s3.us-east-2.amazonaws.com/{s3_... approach.
KyleDolezal
approved these changes
Jan 14, 2024
haileyplusplus
pushed a commit
to haileyplusplus/chn-ghost-buses
that referenced
this pull request
Apr 1, 2024
…t-workaround Use full s3 URL for ConnectionTimeoutError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Line 235 of
compare_scheduled_and_rt.pythrows abotocore.exceptions.ConnectionTimeoutErroror abotocore.exceptions.EndpointConnectionError. Using thes3URL gets around this problem.Resolves #59
Type of change
How has this been tested?
Locally