Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directories for geojson output and plots #14

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

dcjohnson24
Copy link
Collaborator

Description

This pull request adds top-level directories for JSON output and data visualization. This will help with data exploration and sharing results.

Resolves #13

Type of change

  • Bug fix
  • New functionality
  • Documentation

How has this been tested?

This has been tested by adding directories to a local repository.

Copy link
Member

@lauriemerrell lauriemerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, I think I don't understand how you're using negation in the gitignore

@@ -5,9 +5,17 @@ venv
.vscode
.env

*.geojson
# ignore files in scratch subfolder in plots and data_output folders
!data_output/scratch/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit confused by this -- do we want both !path and path? I thought ! would cancel this out

Copy link
Collaborator Author

@dcjohnson24 dcjohnson24 Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is confusing. I probably should have added a comment for this. So ! acts as a keep because it is a .gitignore file. !data_output/scratch/* will keep the folder structure and data_output/scratch/* will ignore the contents of the subfolder scratch. This way, the folders will exist, but files added to scratch won't be under version control. See https://stackoverflow.com/questions/1248570/how-do-i-tell-git-to-ignore-everything-except-a-subdirectory.

@lauriemerrell lauriemerrell merged commit ab8c1be into chihacknight:main Sep 14, 2022
haileyplusplus pushed a commit to haileyplusplus/chn-ghost-buses that referenced this pull request Apr 1, 2024
Add directories for geojson output and plots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data] Add directories for JSON output and plots
2 participants