Let undo can restore multiple pharses at one time #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we removed multiple pharses at one time, and we want to undo that. We only can restore single pharse many times in the past. Now we can restore them in one time.
jserv
reviewed
May 19, 2017
jserv
reviewed
May 19, 2017
jserv
reviewed
May 19, 2017
jserv
reviewed
May 19, 2017
src/model/UserphraseModel.cpp
Outdated
| userphrase_.erase(userphrase_.begin() + index); | ||
| } else { | ||
| qWarning() << "chewing_userphrase_remove() returns" << ret; | ||
| } | ||
| // FIXME: Handle chewing_userphrase_remove fails. | ||
| } | ||
|
|
||
| maxundocnt = remove_cnt; |
There was a problem hiding this comment.
I want to store how many pharses can be restored at one time.
How can I do that better?
There was a problem hiding this comment.
Simply use STL iterator to traverse.
There was a problem hiding this comment.
Did you mean I should add a new STL like vector and don't use a simple global variable?
There was a problem hiding this comment.
How about create a dummy Userpharse as divider between each operation?
There was a problem hiding this comment.
I use vector to store in new commit
Is there any question?
After modifying, it can restore multiple phrases after restore single phrase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add some code to fix #213.
If we removed multiple pharses at one time, and we want to undo that.
We only can restore single pharse many times in the past.
Now we can restore them in one time.