Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowering recall threshold #912

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

scicco
Copy link

@scicco scicco commented Sep 16, 2024

Description

This is my first attempt to try to contribute a bit to this awesome project😹
This commit will lower the recall threshold. It also separates the config introducing the RecallSettings class as suggested in TODO

I've set the following constant values:

    DEFAULT_K = 3
    DEFAULT_TRESHOLD = 0.5

please let me know if those values are appropriate.

Related to issue (#909)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@valentimarco
Copy link
Collaborator

Thx for the contribution! For me is ok but i would prefer to have a central module to store all classes like this one. What do you think @pieroit ?

core/cat/looking_glass/recall_settings.py Outdated Show resolved Hide resolved
@pieroit
Copy link
Member

pieroit commented Nov 1, 2024

@scicco sorry for the delay, left some suggestions. Let me know if you can do it or I'll try

Copy link
Member

@pieroit pieroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

@scicco
Copy link
Author

scicco commented Nov 2, 2024

No problem, I'll work on that

@scicco scicco force-pushed the features/lower_default_treshold_for_recall branch 2 times, most recently from 97cc8c3 to ad5f3b5 Compare November 3, 2024 21:51
@scicco
Copy link
Author

scicco commented Nov 3, 2024

Hello @pieroit, I've implemented the changes. If something should be changed or fixed, let me know, and I'll do it.

Thank you

@scicco scicco force-pushed the features/lower_default_treshold_for_recall branch from ad5f3b5 to 2006338 Compare November 3, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants