Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add python linter #847

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Conversation

valentimarco
Copy link
Collaborator

Description

Add Ruff as pre-commit hook and CI/CD to the repo.
Ruff is an extremely fast Python linter and code formatter, written in Rust. It's added as dependency in the container, so anyone can choose to use it as hook or as CLI command!

To resolve all error, use ruff format

Related to issue #815

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@valentimarco valentimarco reopened this Jun 9, 2024
As discuss in the dev-meeting, we merge all workflows in one and remove pre-commit script
@pieroit pieroit merged commit 808b4a0 into cheshire-cat-ai:develop Jun 24, 2024
0 of 2 checks passed
@pieroit
Copy link
Member

pieroit commented Jun 24, 2024

Thanks @valentimarco fixed all the warnings by ruff
Using this command:
docker exec cheshire_cat_core ruff check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants