Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed embed_tools from MadHatter #413

Closed
wants to merge 2 commits into from
Closed

Removed embed_tools from MadHatter #413

wants to merge 2 commits into from

Conversation

Pingdred
Copy link
Member

Description

As discussed i try to move the embed_tools method from the MadHatter to ChechireCat.

Furthermore i added in CheshireCat the following methods that take care to interact with the MadHatter and the vector memory to embed tools :

  • load_plugins
  • install_plugin
  • uninstall_plugin
  • toggle_plugin

In addition the previous methods add a layer of abstraction to the components of the CheshireCat simplifying, in my opinion, the interaction with the plugin in the code and improve the readability.

@pieroit @nicola-corbellini let me know what do you think about this solution.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@Pingdred Pingdred closed this Oct 11, 2023
@Pingdred Pingdred deleted the move_tools_embedding branch November 2, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant