Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced MadHatter access to db #405

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Reduced MadHatter access to db #405

merged 2 commits into from
Aug 8, 2023

Conversation

Pingdred
Copy link
Member

@Pingdred Pingdred commented Aug 7, 2023

Description

Get active plugins from DB only when find_plugins is called (find_plugins is called also at MadHatter init), when a plugin is activated/deactivated the DB is kept in sync saving the new list of active plugins.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Get active plugins from DB at init.
When a plugin is activated/deactivated the DB is kept in sync saving the new list of active plugins
@pieroit pieroit merged commit 9fc9434 into cheshire-cat-ai:develop Aug 8, 2023
2 checks passed
@pieroit
Copy link
Member

pieroit commented Aug 8, 2023

Thanks

@Pingdred Pingdred deleted the reduce_db_access branch August 10, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants