Progress bar for storing process

[varrialeciro]

Description

Added a monitoring for percentage monitoring of storing process.
Using the notification list, every 10% of file ingestion, a notification is sent to the admin. The step resolution is variable with parameters "percResolution" that in my PR is set to 10. These are modification core side, the idea (with @Alwe help) could be to modify the admin adding a progress bar that change using the percentage received in the notification.

I opened a new PR because i don't know how can add these modification to the old PR. Sorry :/

Related to issue #(issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas

[pieroit]

Thanks @varrialeciro this is wonderful - I'll take a look soon.

A couple of things:

• please make your PRs from and to the develop branch
• do not merge another branch into your feature branch (commits get duplicated)
  💯

[varrialeciro]

Yea, i didn't noticed that, thanks for clarifications.

[nicola-corbellini]

Here is just a comment for @pieroit about future steps.
Is this is a good moment to think about moving notifications to a dedicated class or maybe it is an overkill?

[nicola-corbellini]

We have an utility to print stuff in the terminal. It would be much appreciated if you please could change this and further print as follows:

from cat.log import log

log(text, "INFO")

there are many logging level available, but I think "INFO" is suitable for the purpose.

[varrialeciro]

Merging you can delete that print, were for debugging, I forgot to remove it.

[pieroit]

@varrialeciro yes take away the prints please, use log(message, "INFO") :)
Also variables like perc100 and percResolution shoud be snake_case (perc_100, perc_resolution)

Sorry for being picky, we have a lot going on in develop and would like to merge this PR stright away ;)

Thank you for your patience

[pieroit]

Here is just a comment for @pieroit about future steps. Is this is a good moment to think about moving notifications to a dedicated class or maybe it is an overkill?

Thanks for reviewing @nicola-corbellini !
I think it is a good idea to have classes both for notifications and messages, let's merge this and then design them

[pieroit]

@varrialeciro yes take away the prints please, use log(message, "INFO") :)
Also variables like perc100 and percResolution shoud be snake_case (perc_100, perc_resolution)

Sorry for being picky, we have a lot going on in develop and would like to merge this PR stright away ;)

Thank you for your patience

[varrialeciro]

Updated as you said, removed the debugging print and renamed in snake_case the variables.

[pieroit]

Hi @varrialeciro thank you for this, lots of people wanted a progress bar and this is a good move towards it.
The percentages in the notifications went way over 100% (sometime 140%), I tried to fix but I ended up sending notifications based on time: a rabbit thought every x seconds.

Welcome as a contributor :D

Thanks also @nicola-corbellini for reviewing