Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and managed ingestion status for files/url #380

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

varrialeciro
Copy link
Contributor

Description

Added an ingestion status in the class of rabbit hole in order to handle a progress status during ingestion of files and urls.

Related to issue #337

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@pieroit
Copy link
Member

pieroit commented Jul 28, 2023

Hi @varrialeciro I'm not convinced this is the way to go. If the file is big, we need a progress bar, even if approximate.

Can you please send a small PR with just the edits on core/Dockerfile and core/cat/routes/websocket.py? That I'll merge instantly thanks

@pieroit pieroit merged commit 1b1faba into cheshire-cat-ai:develop Aug 4, 2023
2 checks passed
@pieroit
Copy link
Member

pieroit commented Aug 4, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants