Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sourcery Starbot ⭐ refactored chescales/adminfilters #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sourcery Starbot ⭐ refactored chescales/adminfilters #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions adminfilters/list_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,10 @@ def lookups(self, request, model_admin):
human-readable name for the option that will appear
in the right sidebar.
"""
list_of_questions = []
queryset = Breed.objects.order_by('species_id')
if self.related_filter_parameter in request.GET:
queryset = queryset.filter(species_id=request.GET[self.related_filter_parameter])
for breed in queryset:
list_of_questions.append(
(str(breed.id), breed.name)
)
list_of_questions = [(str(breed.id), breed.name) for breed in queryset]
Comment on lines -30 to +33
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function BreedListFilter.lookups refactored with the following changes:

return sorted(list_of_questions, key=lambda tp: tp[1])

def queryset(self, request, queryset):
Expand Down Expand Up @@ -71,12 +67,8 @@ def lookups(self, request, model_admin):
human-readable name for the option that will appear
in the right sidebar.
"""
list_of_species = []
queryset = Species.objects.all()
for species in queryset:
list_of_species.append(
(str(species.id), species.name)
)
list_of_species = [(str(species.id), species.name) for species in queryset]
Comment on lines -74 to +71
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function SpeciesListFilter.lookups refactored with the following changes:

return sorted(list_of_species, key=lambda tp: tp[1])

def queryset(self, request, queryset):
Expand Down