Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hab plan file for windows and linux to build hab pkg #1840

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

sanghinitin
Copy link

Hab plan file for windows and linux to build hab pkg

@sanghinitin sanghinitin requested review from a team as code owners September 17, 2024 05:35
habitat/plan.sh Outdated
build_line "Installing gems from git repos properly ..."
build_line "Installing this project's gems ..."
bundle exec rake install:local
gem install chef-utils chef-config

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanghinitin why we are installing these gem manually. In Gemfile we specify this gem to download from there respective repo and use main branch. gem install use from rubygem.org

Signed-off-by: nitin sanghi <[email protected]>

Quality Gate failed Quality Gate failed

Failed conditions
1 New issue
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

.byebug_history Outdated
@@ -0,0 +1 @@
next

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file need to be removed

Signed-off-by: nitin sanghi <[email protected]>
@tpowell-progress tpowell-progress self-assigned this Oct 1, 2024
Signed-off-by: nikhil2611 <[email protected]>
Copy link

Copy link

@sean-simmons-progress sean-simmons-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea here to also build this using expeditor? If so we need to configure the pipeline to do so.

@sanghinitin
Copy link
Author

Is the idea here to also build this using expeditor? If so we need to configure the pipeline to do so.

we will add later, all components required pipeline

@sanghinitin sanghinitin changed the base branch from main to workstation-LTS October 28, 2024 09:58
@tpowell-progress
Copy link
Contributor

@sanghinitin following up

@sanghinitin
Copy link
Author

@sanghinitin following up

#1842

@nikhil2611 nikhil2611 merged commit 30ed862 into workstation-LTS Dec 6, 2024
30 of 31 checks passed
@nikhil2611 nikhil2611 deleted the hab_plan_pkg branch December 6, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants