Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive read format raw #83

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Archive read format raw #83

wants to merge 4 commits into from

Conversation

sj26
Copy link
Contributor

@sj26 sj26 commented Aug 13, 2023 •
edited
Loading

Description

Allow reading archives in raw format. Without this change it's impossible to read gzip, bzip2, etc formats which are compression only without monkeying around with Archive::C.archive_read_support_format_raw directly.

I've also made some of the reader methods slightly more consistent, in a backwards-compatible way.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@sj26
Allow specifying reader params at top level
1e70577 
Signed-off-by: Samuel Cochran <[email protected]>
@sj26
Consistency with other methods
5ff2452 
Signed-off-by: Samuel Cochran <[email protected]>
@sj26
Streams can also use filter commands
e123842 
Signed-off-by: Samuel Cochran <[email protected]>
@sj26
Allow reading raw formats
8cf1210 
This allows reading gzip, bzip2, etc which are compression-only with no
underlying archive format. Without running
`archive_read_support_format_raw` on the archive this will raise an
error.

Signed-off-by: Samuel Cochran <[email protected]>
@sj26 sj26 requested review from a team as code owners August 13, 2023 02:53
@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tpowell-progress tpowell-progress self-assigned this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tpowell-progress tpowell-progress

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sj26 @tpowell-progress