Allow opening archive from IO instance #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sj26 Can you intentionally trigger the closed FD error? Wondering if it's something we can prevent from bubbling up. |
|
@sj26 Also, you'll need to rebase from main to merge |
This is discrete from fd because if we pass an fd into libarchive then the caller is reponsible for making sure the opened of the fd survives for the lifetime of the archive instance, but passing in an IO and holding a reference in an instance variable ties the lifetime to the archive instance and allows GC to work as per normal. Signed-off-by: Samuel Cochran <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@sj26 any thoughts on the FD error trapping? I'm assuming this bubbles up through the ffi from C? |
|
Sorry, that's getting out of my depth 😅 I've seen some errors, but I can't reliably replicate. Perhaps this isn't the issue I thought? I'm not sure. It's at the mercy of Ruby GC and object finalization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow opening an archive from an
#<IO>instance, like a#<File>. This is different to opening an FD because it will hold a reference to the IO in Ruby, within the Archive instance, ensuring the lifetime of the IO instance is tied to the lifetime of the Archive::Reader instance, as a nice way to ensure libarchive won't read from an FD that Ruby has since closed by GC'ing the IO instance.Note there is no memory leak etc, the worst that currently happens is an error about reading from a closed FD. But this interface makes the FFI binding a nicer Ruby citizen.
Related Issue
Previously discussed in #75.
Types of changes
Checklist: