-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Building ruby against LTS channel for erchef. #3958
Open
talktovikas
wants to merge
32
commits into
CHEF-11677/CHEF-12498/lbaker
Choose a base branch
from
LTS-2024-erlang-ruby-building
base: CHEF-11677/CHEF-12498/lbaker
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DO NOT MERGE] Building ruby against LTS channel for erchef. #3958
talktovikas
wants to merge
32
commits into
CHEF-11677/CHEF-12498/lbaker
from
LTS-2024-erlang-ruby-building
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
It's old and unmaintained, and now it won't compile without warnings. the last commit was 6-10 years ago. Most of the tools within it now have more updated equivalents elsewhere. Choices: 1) just remove it 2) fork it, fix compile errors, maintain it 3) remove it, then when and where needed, use updated equivalents. For now, going with #1. Signed-off-by: Lincoln Baker <[email protected]>
Fix undefined type error and syntax error. Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
… update. term_to_binary changed. This option is now needed in order to maintain current behavior and avoid failures. Signed-off-by: Lincoln Baker <[email protected]>
It's probably not good to have some calls using this option and other calls not using it. Signed-off-by: Lincoln Baker <[email protected]>
2) /_stats API endpoint returns prometheus output ?format=text Failure/Error: expect(names.uniq).to match_array(PROMETHEUS_RESPONSE_TYPE_MAP.keys) expected collection contained: ["chef_index_batch_completed_latency_ms_bucket", "chef_index_batch_completed_latency_ms_count", "chef... "pg_stat_tidx_blks_read", "pg_stat_toast_blks_hit", "pg_stat_toast_blks_read", "pg_stat_tup_fetch"] actual collection contained: ["chef_index_batch_completed_latency_ms_bucket", "chef_index_batch_completed_latency_ms_count", "chef... "pg_stat_tidx_blks_read", "pg_stat_toast_blks_hit", "pg_stat_toast_blks_read", "pg_stat_tup_fetch"] the missing elements were: ["erlang_mnesia_committed_transactions", "erlang_mnesia_failed_transactions", "erlang_mnesia_held_loc...d_transactions", "erlang_mnesia_transaction_coordinators", "erlang_mnesia_transaction_participants"] # ./spec/api/stats_spec.rb:218:in `block (2 levels) in <top (required)>' Signed-off-by: Lincoln Baker <[email protected]>
Erlang changed this from a default option to an option which now has to be specified, causing failures in SSL when using a self-signed cert. 1) Server-side reindexing reindexing OPC it should behave like Reindexing works for all object types Failure/Error: identifiers.should_not include(name) expected ["pedant_node_test"] not to include "pedant_node_test" Shared Example Group: "Reindexing" called from ./spec/api/reindex_spec.rb:20 # ./lib/pedant/rspec/search_util.rb:932:in `block in do_search' # ./lib/pedant/rspec/search_util.rb:769:in `with_search_polling' # ./lib/pedant/rspec/search_util.rb:919:in `do_search' # ./lib/pedant/rspec/search_util.rb:888:in `should_not_find' # ./lib/pedant/rspec/search_util.rb:950:in `block (2 levels) in <module:RSpec>' Signed-off-by: Lincoln Baker <[email protected]>
… true)" This reverts commit d476605.
Signed-off-by: RoyShravani <[email protected]> testing with LTS-2024 Signed-off-by: RoyShravani <[email protected]> adding studio secrets adding studio secretes Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
👷 Deploy Preview for chef-server processing.
|
Signed-off-by: talktovikas <[email protected]>
Signed-off-by: talktovikas <[email protected]>
Quality Gate passedIssues Measures |
talktovikas
changed the base branch from
main
to
CHEF-11677/CHEF-12498/lbaker
December 16, 2024 07:57
talktovikas
changed the base branch from
CHEF-11677/CHEF-12498/lbaker
to
CHEF-11677/CHEF-12498/lbaker.1208-experimental-fixes
December 16, 2024 07:57
talktovikas
changed the base branch from
CHEF-11677/CHEF-12498/lbaker.1208-experimental-fixes
to
CHEF-11677/CHEF-12498/lbaker
December 16, 2024 07:57
talktovikas
changed the title
WIP | Building ruby against LTS channel for erchef.
Building ruby against LTS channel for erchef.
Dec 18, 2024
jashaik
changed the title
Building ruby against LTS channel for erchef.
[DO NOT MERGE] Building ruby against LTS channel for erchef.
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://progresssoftware.atlassian.net/browse/CHEF-12507
[Please describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List