Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHEF-6088 CHEF-6094 CHEF-6107] Cookie policy, Privacy policy, logo and favicon changes #3737

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ayush-billore
Copy link
Contributor

@ayush-billore ayush-billore commented Nov 15, 2023

Description

  • Adds cookie policy
  • Update logo
  • Update favicon

https://chefio.atlassian.net/browse/CHEF-6088
https://chefio.atlassian.net/browse/CHEF-6094
https://chefio.atlassian.net/browse/CHEF-6107

Screenshot 2023-11-22 at 3 43 57 PM

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]

Check List

@ayush-billore ayush-billore requested review from a team as code owners November 15, 2023 08:28
Copy link

netlify bot commented Nov 15, 2023

👷 Deploy Preview for chef-server processing.

Name Link
🔨 Latest commit 5912ac6
🔍 Latest deploy log https://app.netlify.com/sites/chef-server/deploys/657a98fec6e50600087deef2

@ayush-billore ayush-billore force-pushed the cookie-privacy-logo-changes branch 3 times, most recently from e1403ff to 1c0369c Compare November 16, 2023 11:07
@ayush-billore ayush-billore self-assigned this Nov 22, 2023
@ayush-billore ayush-billore force-pushed the cookie-privacy-logo-changes branch from 1c0369c to a5ad892 Compare November 22, 2023 10:24
@RoyShravani
Copy link
Contributor

LGTM!

@ayush-billore ayush-billore force-pushed the cookie-privacy-logo-changes branch from a5ad892 to a6b6049 Compare December 1, 2023 08:31
@ayush-billore ayush-billore force-pushed the cookie-privacy-logo-changes branch from a6b6049 to 54cf85c Compare December 13, 2023 09:00
Copy link
Member

@marcparadise marcparadise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but needs a rebase to getverification passing.

Please also update the commit message to include a summary of the change and the reason the change is being implemented. ..

- add cookie policy to the footer
- update logos to reflect current Progress Chef brand.
- update favicon to reflect current Progress Chef brand.

Signed-off-by: ayush-billore <[email protected]>
@ayush-billore ayush-billore force-pushed the cookie-privacy-logo-changes branch from 54cf85c to 5912ac6 Compare December 14, 2023 05:56
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ayush-billore
Copy link
Contributor Author

ayush-billore commented Dec 14, 2023

This looks fine, but needs a rebase to getverification passing.

Please also update the commit message to include a summary of the change and the reason the change is being implemented. ..

Thanks for the suggestion @marcparadise

I have added following text as commit message -

The PR adds following GDPR complaiance related changes to OCID component
- add cookie policy to the footer
- update logos to reflect current Progress Chef brand.
- update favicon to reflect current Progress Chef brand.

Signed-off-by: ayush-billore <[email protected]>

@jashaik jashaik merged commit 3577192 into main Dec 14, 2023
6 of 10 checks passed
@jashaik jashaik deleted the cookie-privacy-logo-changes branch December 14, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants