Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected server_name field value which was coming empty after upgrade #8711

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

rensycthomas
Copy link
Collaborator

🔩 Description: What code changed, and why?

Fixed the issue of server_name coming empty in both automate and chefserver configs after upgrade.
server_name comes under the opensearch.ssl section

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Automate Config Before Fix

AutomateConfigBeforeFix

Chef Config Before Fix

CSConfigBeforeFix

Automate Config After Fix

AutomateConfigAfterFix

Chef Config After Fix

CSConfigAfterFix

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit deaa30e
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/67691574b2c0210008b3fc2c
😎 Deploy Preview https://deploy-preview-8711--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rensycthomas rensycthomas requested a review from a team as a code owner December 23, 2024 07:46
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Dec 23, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@punitmundra punitmundra merged commit 99f3393 into main Dec 24, 2024
11 of 13 checks passed
@punitmundra punitmundra deleted the rt/CHEF-17923_correct_server_name_field_value branch December 24, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants