Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checklist for v5 for opensearch and postgres #8706

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sahiba3108
Copy link
Collaborator

@Sahiba3108 Sahiba3108 commented Dec 18, 2024

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

https://progresssoftware.atlassian.net/browse/CHEF-17453

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Screenshot 2024-12-26 at 12 15 33β€―PM

@Sahiba3108 Sahiba3108 self-assigned this Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

βœ… Deploy Preview for chef-automate ready!

Name Link
πŸ”¨ Latest commit 1a3a18d
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/676cfb44b283170008c67b32
😎 Deploy Preview https://deploy-preview-8706--chef-automate.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sahiba3108 Sahiba3108 changed the base branch from main to milestone_release_for_v5 December 18, 2024 14:08
@Sahiba3108 Sahiba3108 changed the base branch from milestone_release_for_v5 to main December 18, 2024 14:08

Quality Gate failed Quality Gate failed

Failed conditions
12 New issues
44.0% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant