Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FQDN check should pass/fail after retrying mutliple times to reach the node #8244

Merged
merged 11 commits into from
Oct 23, 2023

Conversation

ArvinthC3000
Copy link
Collaborator

@ArvinthC3000 ArvinthC3000 commented Oct 3, 2023

🔩 Description: What code changed, and why?

As an Automate HA user, when I try to run the verify command with my configuration, the FQDN error is generic. It should be detailed on the error

⛓️ Related Resources

Jira: https://chefio.atlassian.net/browse/CHEF-6048

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Demo Video: https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/EZdDU_9hw0BEgZEA0p401RgBBCeJCmQRTfDEqMhkzL-fJw?e=qV3RKz

@netlify
Copy link

netlify bot commented Oct 3, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 55e1251
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/652ea1eb25ef2e0008abd823

@ArvinthC3000 ArvinthC3000 self-assigned this Oct 6, 2023
@ArvinthC3000 ArvinthC3000 requested a review from Dmaddu October 6, 2023 13:48
Dmaddu
Dmaddu previously requested changes Oct 11, 2023
Copy link
Collaborator

@Dmaddu Dmaddu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipelines are failing, could you please fix it

Signed-off-by: Arvinth C <[email protected]>
@ArvinthC3000 ArvinthC3000 requested a review from a team as a code owner October 12, 2023 10:36
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Oct 12, 2023
@sonarqube-for-infrastructure-prod

@ArvinthC3000 ArvinthC3000 requested a review from Dmaddu October 18, 2023 05:40
@ArvinthC3000 ArvinthC3000 dismissed Dmaddu’s stale review October 18, 2023 05:41

Pipeline is fixed

@punitmundra punitmundra merged commit 3423886 into main Oct 23, 2023
@punitmundra punitmundra deleted the ar/fqdn_check branch October 23, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants