-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FQDN check should pass/fail after retrying mutliple times to reach the node #8244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e node Signed-off-by: Arvinth C <[email protected]>
👷 Deploy Preview for chef-automate processing.
|
ArvinthC3000
requested review from
Sahiba3108,
YashviJain01,
vivek-yadav,
jayvikramsharma1,
punitmundra and
bvtejaswi
October 3, 2023 05:32
Signed-off-by: Arvinth C <[email protected]>
Signed-off-by: Arvinth C <[email protected]>
Signed-off-by: Arvinth C <[email protected]>
Signed-off-by: Arvinth C <[email protected]>
jayvikramsharma1
approved these changes
Oct 10, 2023
Dmaddu
requested changes
Oct 10, 2023
Signed-off-by: Arvinth C <[email protected]>
Signed-off-by: Arvinth C <[email protected]>
Dmaddu
approved these changes
Oct 11, 2023
Dmaddu
previously requested changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pipelines are failing, could you please fix it
Signed-off-by: Arvinth C <[email protected]>
punitmundra
approved these changes
Oct 12, 2023
Signed-off-by: Arvinth C <[email protected]>
github-actions
bot
added
the
documentation
Anything related to the Automate docs.
label
Oct 12, 2023
Signed-off-by: Arvinth C <[email protected]>
Signed-off-by: Arvinth C <[email protected]>
SonarQube Quality Gate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
As an Automate HA user, when I try to run the verify command with my configuration, the FQDN error is generic. It should be detailed on the error
⛓️ Related Resources
Jira: https://chefio.atlassian.net/browse/CHEF-6048
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Demo Video: https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/EZdDU_9hw0BEgZEA0p401RgBBCeJCmQRTfDEqMhkzL-fJw?e=qV3RKz