Winrm options defaults / precedence #454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the log gets long, it may only give us a small amount, Missing important information towards the end
If not cached in the reference, connect to the ip/port and compare them to the supplied ssl_fingerprint, then cache.
| encoded_output = instance.console_output.data.output | ||
| console_lines = Base64.decode64(encoded_output).lines | ||
| fp_context = OpenSSL::SSL::SSLContext.new | ||
| tcp_connection = TCPSocket.new(instance.private_ip_address, port) |
There was a problem hiding this comment.
Hey @hh - why are you using the private_ip_address here? When I try to connect to an https connection using this PR I get the following error
https://gist.github.com/tyler-ball/73996b85e155ab76cfa2280ecac6c71d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is on top of #441 due to the code being changed in both PRs