testing git-diff #40
testing git-diff #40
Conversation
|
I have been reading about this CI command added git-diff, but struggle to understand. To my understanding, CI checks out my PR and compares the changes with the latest code available on remote. And, if any untracked changes, then it will fail. For instance, i have untracked changes in this PR in my local. But, the job seems to succeed. |
|
https://github.com/checkstyle/test-configs/actions/runs/9578108855/job/26407651096?pr=40#step:5:204 test is not failed, even it is crashed with exception and produced no output. I checked it on local, no diff on local. |
|
you will improve at scope of this issue - #41 |
|
@relentless-pursuit , please rebase |
relentless-pursuit
force-pushed
the
PR8
branch
2 times, most recently
from
9a9af97 to
55da0c7
Compare
…le config specified
|
Rebased. But, i am not sure how this git diff works? Shouldn't the job be pointing to new files added liek clone the latest checkstyle test-config and compare with the PR? |
|
No, it just do git status on PR code after execution. Create new file in git repository from test execution and it should be caught |
yes, i did. but, i guess i didn't see any failure. i created a folder from mainslaunchertest.java and then i first kept them in unstaged. but, the job didn't fail. then in the next commit, i put them in the staging and did commit. |
|
New empty folder is not status changed for git, please create file |
| @@ -0,0 +1,34 @@ | |||
| <?xml version="1.0"?> | |||
| <!DOCTYPE module PUBLIC | |||
There was a problem hiding this comment.
Remove from commit this folder and it should be caught
I had actually created a complete folder with config.xml. Except, i didn't commit but kept in unstaged env. Yes, i will act on the review and test again. |
|
It works, see it here https://github.com/checkstyle/test-configs/actions/runs/9635984919/job/26573394995?pr=53#step:6:30 I think you can close this PR |
|
Closing the PR as testing is validated. |
Part of #1