Issue #213: update to CS 8.20 #216
Conversation
|
Please share some prove that new Check can do violation reporting ( any violation) to make sure basic testing was done. |
|
|
|
please rebase on latest master, to make CI green. |
muhlba91
force-pushed
the
feature/issue-213
branch
from
20df2d1 to
388ed37
Compare
|
@romani - CI runs through except TC. TC still tries to look for |
|
do we want to release 4.20 now , or should we wait something ? |
|
In my opinion nothing is against not releasing it now. I wouldn't see major/important issues open which should get fixed before a release. :) However, since |
|
lets wait for 1-2 week ... please provide update to wiki page on new release process. |
|
perfect :) I already updated the wiki page a few days ago. Steps 1-6 stay the same and there's only a step 7.1 and 7.2 now. |
| @@ -894,6 +894,19 @@ | |||
| <txt>min</txt> | |||
| </prop> | |||
| </chc> | |||
| <chc> | |||
| <rule-repo>checkstyle</rule-repo> | |||
| <rule-key>com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck</rule-key> | |||
There was a problem hiding this comment.
@muhlba91 Does every module need to be listed here?
It doesn't seem to be part of our test to verify everything is listed in here. https://github.com/checkstyle/sonar-checkstyle/blob/master/src/test/java/org/sonar/plugins/checkstyle/internal/ChecksTest.java#L87-L94
There was a problem hiding this comment.
I don't use SQALE on my instances but I don't think it's necessary since, afaik, if it's not listed iit doesn't have an impact on the score?
However, I added it because there were other Javadoc checks present and I kept it on-par with them. Do we have any rules for the SQALE stuff?
Anyhow, how is SQALE the SQALE support in SonarQube atm? At least in the API I read that it got deprecated:
- http://javadocs.sonarsource.org/7.7/apidocs/deprecated-list.html and search for SQALE
- https://jira.sonarsource.com/browse/SQALE-277?jql=project%20%3D%20SQALE -> the project is named "[DEPRECATED] SQALE"
There was a problem hiding this comment.
This is my first time seeing it so I don't believe there are any rules. I don't know what SQALE is so I couldn't identify what needs to be done with it.
Unless you or @romani know more, I suggest we just create an issue for a test to verify it has valid information and not require checks be listed.
Edit:
From looking online, it looks like it is just listing what debt the check creates when a violation is found. I think @romani had some hesitation on this since it is subjective. It couldn't hurt to list every check for another issue but I am not sure we would really look into the values suggested.
There was a problem hiding this comment.
this config came from Sonarqube team.
I never understand how to it is possible to estimate fix in time, in most cases it does work at all.
Such estimations NEVER worked well, it was only source of laugh ..... ones you spend a day with "10 min fix".
If Sonar do not demand such config be for each rule - I would be happy to remove them completely.
There was a problem hiding this comment.
ah ok, I'll see if Sonar is happy when the file is empty/removed. I think the listed checks are anyways not up to date with all checks available.
If so, we can remove it and also don't have to copy over the SQALE source code from sslr. Will create an issue on that latest tomorrow. :)
Fixes #213.
Please adapt CI first after the merge of #214 to have a clean CI run for this PR.