Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default locale to avoid tests failed on non-English machine. #368

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

asakaxgit
Copy link
Contributor

Roughly fixed issue #367.
Any side effects are out of consideration, but it works.

#367

@romani
Copy link
Member

romani commented Sep 1, 2024

Thanks a lot , please fix CI failures

@rnveach
Copy link
Member

rnveach commented Sep 1, 2024

@romani CI failures are because this repo is abandoned. Not related to this PR.

@romani
Copy link
Member

romani commented Sep 2, 2024

Link should be https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java-regexp.header

At

checkstyle.regexp.header.file=https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java_regexp.header

@asakaxgit , please do this update in same PR.

@asakaxgit asakaxgit marked this pull request as draft September 3, 2024 01:43
@asakaxgit asakaxgit marked this pull request as ready for review September 3, 2024 01:49
@asakaxgit
Copy link
Contributor Author

Link should be https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java-regexp.header

At

checkstyle.regexp.header.file=https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java_regexp.header

@asakaxgit , please do this update in same PR.

Fixed.
d52dfdc
52d2291

@romani romani merged commit 6d38758 into checkstyle:master Sep 3, 2024
romani pushed a commit that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants