refactor: org.openrewrite.staticanalysis.IsEmptyCallOnCollections

checkstyle · Jan 19, 2025 · 39c643c · 39c643c
1 parent 1e3bbd2
commit 39c643c
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 9 deletions.
diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java
@@ -145,7 +145,7 @@ public static ICheckConfiguration getDefaultCheckConfiguration() {
       return sDefaultCheckConfig;
     } else if (sDefaultBuiltInConfig != null) {
       return sDefaultBuiltInConfig;
-    } else if (sConfigurations.size() > 0) {
+    } else if (!sConfigurations.isEmpty()) {
       return sConfigurations.get(0);
     } else {
       return null;

diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java
@@ -109,7 +109,7 @@ public static void write(OutputStream out, List<Module> modules, ICheckConfigura
       // find the root module (Checker)
       // the root module is the only module that has no parent
       List<Module> rootModules = getChildModules(null, modules);
-      if (rootModules.size() < 1) {
+      if (rootModules.isEmpty()) {
         throw new CheckstylePluginException(Messages.errorNoRootModule);
       }
 

diff --git a/...f.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java b/...f.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java
@@ -167,7 +167,7 @@ public void store() throws CheckstylePluginException {
 
   @Override
   public boolean isDirty() {
-    if (mDeletedConfigurations.size() > 0) {
+    if (!mDeletedConfigurations.isEmpty()) {
       return true;
     }
 

diff --git a/...psecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java b/...psecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java
@@ -110,7 +110,7 @@ public void store() throws CheckstylePluginException {
 
   @Override
   public boolean isDirty() {
-    if (mDeletedConfigurations.size() > 0) {
+    if (!mDeletedConfigurations.isEmpty()) {
       return true;
     }
 

diff --git a/...f.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationFactory.java b/...f.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationFactory.java
@@ -123,7 +123,7 @@ public static IProjectConfiguration getConfiguration(IProject project)
    */
   public static boolean isCheckConfigInUse(ICheckConfiguration checkConfig)
           throws CheckstylePluginException {
-    return getProjectsUsingConfig(checkConfig).size() > 0;
+    return !getProjectsUsingConfig(checkConfig).isEmpty();
   }
 
   /**

diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java
@@ -460,13 +460,13 @@ public boolean performOk() {
               .getString(CheckstyleUIPluginPrefs.PREF_ASK_BEFORE_REBUILD);
 
       boolean rebuild = MessageDialogWithToggle.ALWAYS.equals(promptRebuildPref)
-              && (needRebuildAllProjects || projectsToBuild.size() > 0);
+              && (needRebuildAllProjects || !projectsToBuild.isEmpty());
 
       //
       // Prompt for rebuild
       //
       if (MessageDialogWithToggle.PROMPT.equals(promptRebuildPref)
-              && (needRebuildAllProjects || projectsToBuild.size() > 0)) {
+              && (needRebuildAllProjects || !projectsToBuild.isEmpty())) {
 
         MessageDialogWithToggle dialog = MessageDialogWithToggle.openYesNoQuestion(getShell(),
                 Messages.CheckstylePreferencePage_titleRebuild,

diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java
@@ -93,7 +93,7 @@ public void setFileSets(List<FileSet> fileSets) throws CheckstylePluginException
     mFileSets = fileSets;
 
     ICheckConfiguration config = null;
-    if (mFileSets.size() > 0) {
+    if (!mFileSets.isEmpty()) {
       config = (mFileSets.get(0)).getCheckConfig();
     }
 

diff --git a/...eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java b/...eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java
@@ -133,7 +133,7 @@ private Boolean isReturnStatementTrue(final Statement node) {
           // the return statement might be wrapped in a block statement
           @SuppressWarnings("unchecked")
           final List<Statement> statements = ((Block) node).statements();
-          if (statements.size() > 0) {
+          if (!statements.isEmpty()) {
             return isReturnStatementTrue(statements.get(0));
           }
         }