Issue #529: Final removal of 'launch.groovy' #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrmancuso
force-pushed
the
issue-529-b
branch
3 times, most recently
from
438b283 to
a53d8a2
Compare
nrmancuso
commented
Apr 26, 2021
Comment on lines
-34
to
-43
| checkstyle-tester-launch-groovy) | ||
| checkout_from https://github.com/checkstyle/checkstyle | ||
| cd .ci-temp/checkstyle | ||
| LOCAL_GIT_REPO=$(pwd) | ||
| mvn --batch-mode clean install -Passembly | ||
| cd ../../checkstyle-tester | ||
| groovy diff.groovy -r "$LOCAL_GIT_REPO" -l projects-for-travis.properties --patchConfig my_check.xml \ | ||
| --patchBranch master --mode single --allowExcludes | ||
| ;; | ||
|
|
There was a problem hiding this comment.
This is a duplicate of checkstyle-tester-diff-groovy-patch now that launch is removed, so we can remove this job.
nrmancuso
commented
Apr 26, 2021
Comment on lines
-71
to
-78
| - JAVA_HOME: C:\Program Files\Java\jdk1.8.0 | ||
| DESC: "checkstyle-tester (launch.groovy) on guava" | ||
| CMD1: " git clone -q --depth=10 --branch=master " | ||
| CMD2: " https://github.com/checkstyle/checkstyle C:\\projects\\contribution\\checkstyle " | ||
| CMD3: " && cd checkstyle && mvn clean install -Passembly" | ||
| CMD4: " " | ||
| CMD5: " && cd ..\\checkstyle-tester " | ||
| CMD7: " && groovy launch.groovy -l projects-for-travis.properties -c checks-nonjavadoc-error.xml -i\"" |
There was a problem hiding this comment.
This is duplicated by the checkstyle-tester (diff.groovy) on guava job below.
rnveach
approved these changes
Apr 30, 2021
| 6) execute `groovy launch.groovy --listOfProjects projects-to-test-on.properties | ||
| --config my_check.xml --ignoreExceptions` | ||
| 6) execute `groovy diff.groovy --localGitRepo /home/johndoe/projects/checkstyle --baseBranch i111-my-fix | ||
| --patchBranch i111-my-fix-mutation --config config.xml --listOfProjects projects-to-test-on.properties` | ||
| 7) copy `checkstyle-result.xml` from `checkstyle-tester/reports/project-name/` | ||
| to some other location. |
There was a problem hiding this comment.
It looks like this readme is completely outdated or out of whack. There is no reason for this utility to be an after thought to running diff.groovy as diff.groovy calls it. We should update this in a new issue. I think it should be more standalone since it is it's own utility. We should just specify how to incorporate it.
pbludov
approved these changes
May 1, 2021
romani
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #529
Found:
I will take care of this in a separate commit. Marking this draft until then.