Issue #523: Add extraMvnOptions support to diff.groovy #538
Conversation
|
AppVeyor failure: I think we need to build the string to execute |
|
From checkstyle/checkstyle#9186 at https://checkstyle.semaphoreci.com/jobs/cdce7615-278e-4e64-8d91-68b6b3cef46b:
This shows that the |
If we are converting this script to a Java project, then no. |
| --config $cfg.checkstyleCfg --ignoreExceptions --ignoreExcludes | ||
| --checkstyleVersion $checkstyleVersion""" | ||
|
|
||
| if (cfg.extraMvnRegressionOptions == true) { |
There was a problem hiding this comment.
Strangely, this is required, since if (cfg.extraMvnRegressionOptions) does not work as intended. I assume this is because groovy is not strongly typed.
There was a problem hiding this comment.
Why wasn't this an issue with launch? https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/launch.groovy#L243-L244
There was a problem hiding this comment.
The only difference that I can see is that we are accessing cfg's fields and opposed to actually passing arguments to generateCheckstyleReport()? Should I investigate?
Issue #523: Add extraMvnOptions support to diff.groovy
I am going to open a PR in Checkstyle for checkstyle/checkstyle#8960 in order to show that the arguements are passed to maven correctly.