Issue #530: Remove JXR library from launch.groovy #536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #530: Remove JXR library from launch.groovy
Ok, I wanted to provide as much proof as possible that this change has no ill effects; please let me know what else I can show.
First, a simple example using two repos that I created (note that my
zsh
prompt shows the branch that I am currently on, as well as my notes).One has non-compilable code that should cause exception (
broken-repo
) and one has compilable code (not-broken
) that should( and does) allow for acheckstyle-results.xml
to be generated: https://gist.github.com/nmancus1/d097e9654130329200849742ccf0971cIf anyone would like to verify the above, here are the projects file lines:
Note at the end of the gist above, I diff the two
checkstyle-result.xml
files, successfully.This shows that
launch.groovy
works as intended after removal of JXR and associated code inlaunch.groovy
.The only difference in the end result of
launch.groovy
is that the final report is not correctly cross-linked, as shown in #527 (comment). This is not a problem, because we only use launch.groovy to createcheckstyle-result.xml
files and validate that checkstyle can parse specified repositories.Next,
diff.groovy
useslaunch.groovy
to createcheckstyle-result.xml
files that it compares across branches. So, as proof thatdiff.groovy
still functions as intended, I ran a diff report with config and projects file from checkstyle/checkstyle#9135, found here: https://nmancus1.github.io/remove-jxr-avoidescapes-diff/diff/index.html .It looks like we have lost the links to source files with violations. I am looking into this now, marked as draft.