scripts/uninstall_module: import signal module #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rst0git
force-pushed
the
uninstall_module-import-signal
branch
2 times, most recently
from
4e7ae05 to
5c53af5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # which requires loading the `signal` module: | ||
| # https://docs.python.org/3/whatsnew/3.13.html#subprocess | ||
| # flake8: noqa: F401 | ||
| import signal |
Check notice
Code scanning / CodeQL
Unused import Note
avagin
reviewed
Mar 3, 2025
With Python 3.13, the `subprocess` module now uses the `posix_spawn()` function [1], which requires the `signal` module to be imported. Fixes: checkpoint-restore#2607 [1] https://docs.python.org/3/whatsnew/3.13.html#subprocess Signed-off-by: Radostin Stoyanov <[email protected]>
rst0git
force-pushed
the
uninstall_module-import-signal
branch
from
5c53af5 to
235ec54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Python 3.13, the
subprocessmodule now uses theposix_spawn()function 1, which requires thesignalmodule to be imported.Fixes: #2607
Footnotes
https://docs.python.org/3/whatsnew/3.13.html#subprocess ↩