Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run as root within container #157

Closed
wants to merge 2 commits into from

Conversation

rst0git
Copy link
Member

@rst0git rst0git commented Mar 4, 2025

When running with default user, it fails with the following error:

Run sudo dnf -y install ShellCheck bats golang criu asciidoctor iptables iproute kmod jq bash bash-completion zsh fish
sudo: PAM account management error: Authentication service cannot retrieve authentication info
sudo: a password is required

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.42%. Comparing base (15dd6b5) to head (febf211).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   76.42%   76.42%           
=======================================
  Files          11       11           
  Lines        1442     1442           
=======================================
  Hits         1102     1102           
  Misses        266      266           
  Partials       74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 4, 2025

Test Results

0 tests   - 61   0 ✅  - 61   0s ⏱️ -2s
0 suites  -  1   0 💤 ± 0 
0 files    -  1   0 ❌ ± 0 

Results for commit febf211. ± Comparison against base commit 15dd6b5.

♻️ This comment has been updated with latest results.

@rst0git rst0git force-pushed the ci-test-fix branch 2 times, most recently from e681e98 to 38b36e1 Compare March 4, 2025 13:59
@snprajwal
Copy link
Member

@rst0git the lint job is failing because of an update to the golangci-lint config spec. deadline is now called timeout - we would have to make that change in our .golangci-lint.yml.

rst0git added 2 commits March 4, 2025 14:44
golangci-lint fails with the following error:

Error: Failed to run: Error: Command failed: /home/runner/golangci-lint-1.64.6-linux-amd64/golangci-lint config verify
jsonschema: "run" does not validate with "/properties/run/additionalProperties": additional properties 'deadline' not allowed
Failed executing command with error: the configuration contains invalid elements
, Error: Command failed: /home/runner/golangci-lint-1.64.6-linux-amd64/golangci-lint config verify
jsonschema: "run" does not validate with "/properties/run/additionalProperties": additional properties 'deadline' not allowed
Failed executing command with error: the configuration contains invalid elements

    at genericNodeError (node:internal/errors:984:15)
    at wrappedFn (node:internal/errors:538:14)
    at ChildProcess.exithandler (node:child_process:422:12)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)
Error: Command failed: /home/runner/golangci-lint-1.64.6-linux-amd64/golangci-lint config verify
jsonschema: "run" does not validate with "/properties/run/additionalProperties": additional properties 'deadline' not allowed
Failed executing command with error: the configuration contains invalid elements

Suggested-by: Prajwal S N <[email protected]>
Signed-off-by: Radostin Stoyanov <[email protected]>
When running with default user, it fails with the following error:

sudo: PAM account management error: Authentication service cannot retrieve authentication info
sudo: a password is required

Signed-off-by: Radostin Stoyanov <[email protected]>
@snprajwal
Copy link
Member

#158 should fix this, PTAL

@rst0git rst0git closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants