Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add New Fields and Update Tests for Payments Processing #465

Merged
merged 1 commit into from
Jan 27, 2025
Merged

feat: Add New Fields and Update Tests for Payments Processing #465

merged 1 commit into from
Jan 27, 2025

Conversation

armando-rodriguez-cko
Copy link
Contributor

feat: Add New Fields and Update Tests for Payments Processing

Description:

This PR enhances the payments processing module by introducing new fields to the RequestNetworkTokenSource and ProcessingData classes. Additionally, related tests have been updated to reflect the changes and improve coverage.

Key Changes:

  1. New Fields:

    • RequestNetworkTokenSource:
      • Added storeForFutureUse to support token storage preferences.
      • Included name for capturing cardholder name.
    • ProcessingData:
      • Added panTypeProcessed to identify the type of processed PAN.
      • Introduced ckoNetworkTokenAvailable to indicate network token availability.

  2. Test Enhancements:

    • TestHelper:
      • Updated createHostedPaymentRequest to include displayName for additional context.
    • BankAccountFieldFormattingTestIT:
      • Ensured test handles unavailable scenarios gracefully by marking with @Disabled.
    • RequestApmPaymentsIT:
      • Added validation for the PaymentResponse to confirm successful handling.

Impact:

  • Functionality:
    • Improves flexibility and clarity in handling payment tokens and processing metadata.
  • Security:
    • Enhances data reliability by including fields for better token management.
  • Testing:
    • Strengthened test coverage ensures reliability and better handling of edge cases.

Testing:

  • Successfully validated new fields and updated test cases.
  • Deferred execution for specific tests using @Disabled where necessary.

Notes:

  • Ensure developers are informed about new fields to adapt integrations accordingly.
  • Follow-up PRs may focus on additional test scenarios for further validation.

@armando-rodriguez-cko
feat: add new fields and update tests for payments processing
3333a11 
- Added `storeForFutureUse` field to `RequestNetworkTokenSource` with constructor support.
- Added `panTypeProcessed` and `ckoNetworkTokenAvailable` fields to `ProcessingData`.
- Updated `TestHelper` to include `displayName` in test setup for payments.
- Marked `shouldGetBankAccountFieldFormatting` test as disabled with a note in `BankAccountFieldFormattingTestIT`.
- Refined `RequestApmPaymentsIT` to validate non-null payment response in tests.
@armando-rodriguez-cko armando-rodriguez-cko requested a review from a team January 24, 2025 13:37
@armando-rodriguez-cko armando-rodriguez-cko merged commit e12b0ce into master Jan 27, 2025
4 checks passed
@armando-rodriguez-cko armando-rodriguez-cko deleted the feature/INT-1540-INT-1541-previous-skip-tests branch January 27, 2025 09:23
@armando-rodriguez-cko armando-rodriguez-cko linked an issue Jan 31, 2025 that may be closed by this pull request
Add field store_for_future_use for RequestNetworkTokenSource #460
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavo-porto-cko gustavo-porto-cko gustavo-porto-cko approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add field store_for_future_use for RequestNetworkTokenSource
2 participants
@armando-rodriguez-cko @gustavo-porto-cko