Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Implement persistent storage for PSQL #746

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

kyleecodes
Copy link
Member

@kyleecodes kyleecodes commented Jan 7, 2025

Resolves #588 & implements persistent storage.

N/A

What changes did you make and why did you make them?

  • In a previous update, the backend's dependency overhead was reduced by moving the PostgreSQL database into Docker. This pull request introduces persistent storage by configuring Docker volumes / bind mounts for the PostgreSQL container. With this change, database data will persist even if containers are deleted, ensuring that data remains intact across container restarts. This also eliminates the need for maintainers to manually populate databases in cloned forks when reviewing forked pull requests. The named volume postgres-data ensures cross-compatibility across all operating systems.
  • .env now loaded in docker-compose
  • Respective docs are updated to reflect the change.

Did you run tests? Share screenshot of results:

image

image

How did you find us? (GitHub, Google search, social media, etc.):

@kyleecodes kyleecodes self-assigned this Jan 7, 2025
@kyleecodes kyleecodes changed the title Docker: Persist PSQL Data in Volumes Docker: Implement Persistent PSQL Data in Volumes Jan 7, 2025
@kyleecodes kyleecodes changed the title Docker: Implement Persistent PSQL Data in Volumes Implement persistent storage for PSQL using Docker volumes Jan 13, 2025
@kyleecodes kyleecodes changed the title Implement persistent storage for PSQL using Docker volumes Implement persistent storage for PSQL Jan 13, 2025
@kyleecodes kyleecodes force-pushed the docker/persistent-data branch from bfbe6b4 to 18160cf Compare January 15, 2025 11:50
@kyleecodes kyleecodes removed the request for review from eleanorreem January 15, 2025 11:56
@kyleecodes kyleecodes merged commit 8545452 into develop Jan 15, 2025
4 checks passed
@kyleecodes kyleecodes deleted the docker/persistent-data branch January 15, 2025 11:57
@kyleecodes kyleecodes changed the title Implement persistent storage for PSQL Docker: Implement persistent storage for PSQL Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Compose doesn't load .env file and incorrect DATABASE_URL configuration
1 participant