Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete post /me endpoint #427

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Delete post /me endpoint #427

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ed39c2
delete post /me endpoint as it's going to use get /me endpoint instead
SangilYun May 19, 2024
5f1f911
Merge branch 'refs/heads/develop' into delete-the-POST-/user/me-endpoint
SangilYun Jun 15, 2024
e9da991
merge develop and resolve a conflict
SangilYun Jun 15, 2024
40c48f6
Merge branch 'develop' into delete-the-POST-/user/me-endpoint
chaynteam Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/user/user.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,22 +50,6 @@ export class UserController {
return user as GetUserDto;
}

/**
* This POST endpoint deviates from REST patterns.
* Please use `getUserByFirebaseId` above which is a GET endpoint.
* Safe to delete function below from July 2024 - allowing for caches to clear
*/
@ApiBearerAuth('access-token')
@ApiOperation({
description:
'Returns user profile data with their nested partner access, partner admin, course user and session user data.',
})
@Post('/me')
@UseGuards(FirebaseAuthGuard)
async getUserProfileByFirebaseId(@Req() req: Request): Promise<GetUserDto> {
return req['user'];
}

@ApiBearerAuth()
@Delete()
@UseGuards(FirebaseAuthGuard)
Expand Down
Loading