Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow client_id to be optional on simplybook webhook #349

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

eleanorreem
Copy link
Contributor

@eleanorreem eleanorreem commented Nov 7, 2023

Issue ticket link / number:

N/A - ticket in notion

What changes did you make?

  • made client_id an optional parameter on the simplybook webhook
  • added tests to safeguard change
  • updated other tests as mock data changes had affects on them

Why did you make the changes?

  • errors reported in zapier as users were updating therapy sessions from a link where userId was not available

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@eleanorreem eleanorreem merged commit c64ee27 into develop Nov 7, 2023
@eleanorreem eleanorreem deleted the therapy-webhook-user-id-bug branch November 7, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant