Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to basic auth via bob swift tools failing. #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cooperaj
Copy link

@cooperaj cooperaj commented Mar 3, 2016

  1.   Remove the code to process login() calls, and instead call the com.atlassian.confluence.user.ConfluenceAuthenticator login method.  login() does not seem to get called when authenticating via mod_shib, but does while authenticating via basic auth.  This fixes the issue in #30.
    
  2.   Move a section of code from getFullName to updateUser() so it can check if the user has an existing displayName before falling back to username.  This prevents the display name in Confluence being overwritten if the IdP does not supply it and it has been manually updated in Confluence.
    

…n just pass straight up to the super implementation. This means that the bob swift CLI access works and does not through 401 errors.

Also ensure that the full name of the user is not replaced if it's already been set.
@cooperaj
Copy link
Author

cooperaj commented Mar 3, 2016

This was carried out by a contractor we brought in. I'll be able to manage any requested changes but we do know at this point that the code works as intended.

@garysweaver
Copy link
Contributor

@cooperaj Thanks for your contribution!

Considering the potential impact of this change to others, we'll need to do a beta release and have the community test that before releasing as final.

Can you first send me (here or at my personal email to be more secure) what features of the authenticator you are using with the modified version (create user, update user, etc.) in production currently that you have tested successfully?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants