[17.0][MIG] partner_invoicing_mode_at_shipping: Migration to 17.0 #4

chaule97 · 2024-12-31T04:59:17Z

Take over: [17.0][MIG] partner_invoicing_mode_at_shipping: Migration to 17.0 OCA/account-invoicing#1700
I updated module depend sale_stock because in test case, self.so1.picking_ids needs picking_ids field, and this field in sale_stock module.
test_queue_job_no_delay is no longer available, I have to change to queue_job__no_delay

thienvh332 · 2025-01-03T05:28:59Z

partner_invoicing_mode_at_shipping/__manifest__.py

@@ -12,6 +12,9 @@
        "data/queue_job_data.xml",
        "views/res_partner.xml",
    ],
-    "depends": ["account", "partner_invoicing_mode", "queue_job", "stock"],
+    "depends": ["account", "partner_invoicing_mode", "queue_job", "sale_stock"],


No need for this change.

depends: sale_stock is a module with auto_install = True and depends on the module sale, stock. And in partner_invoicing_mode it depends on sale. So sale_stock is already installed

Suggested change

"depends": ["account", "partner_invoicing_mode", "queue_job", "sale_stock"],

"depends": ["account", "partner_invoicing_mode", "queue_job", "stock"],

thienvh332 · 2025-01-03T05:32:45Z

requirements.txt

+# generated from manifests external_dependencies
+openupgradelib


No need, you have declared it in external_dependencies. No need to add it here.

Pre-commit generate it

thienvh332 · 2025-01-03T05:33:19Z

partner_invoicing_mode_at_shipping/migrations/16.0.1.1.0/pre-migrate.py

thienvh332 · 2025-01-03T05:35:06Z

partner_invoicing_mode_at_shipping/models/stock_move.py

Delete it. No need.
In sale_stock there is already this function with the same function

thienvh332 · 2025-01-03T05:35:33Z

partner_invoicing_mode_at_shipping/models/__init__.py

@@ -0,0 +1,4 @@
+from . import res_partner
+from . import stock_move


Suggested change

from . import stock_move

thienvh332 · 2025-01-03T05:37:23Z

partner_invoicing_mode_at_shipping/readme/CONTRIBUTORS.md

+  > - Thierry Ducrest \<<[email protected]>\>
+
+- Phuc (Tran Thanh) \<<[email protected]>\>
+- Nils Coenen \<<[email protected]>\>


With some changes above you can put your name in this file. This decision depends on you 😉

thienvh332 · 2025-01-03T05:37:55Z

partner_invoicing_mode_at_shipping/readme/CREDITS.md

@@ -0,0 +1,3 @@
+The development of this module has been financially supported by:
+
+- Camptocamp


Update credits

thienvh332 · 2025-01-03T05:40:37Z

partner_invoicing_mode_at_shipping/models/res_partner.py

+                and partner.one_invoice_per_shipping
+            ):
+                raise ValidationError(
+                    _(


Hehe, small changes 😉.

Same with other similar things

Suggested change

_(

self.env._(

Odoo in test CI doesn't know it

thienvh332 · 2025-01-03T08:47:30Z

partner_invoicing_mode_at_shipping/hooks.py

This still needs to be kept.

thienvh332 · 2025-01-03T08:48:29Z

partner_invoicing_mode_at_shipping/models/stock_picking.py

@@ -1,7 +1,7 @@
 # Copyright 2020 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)

-from odoo import _, models
+from odoo import _, api, models


Still exists _() below

thienvh332

LGTM

the `sale.order._create_invoices() method does not only requires `create` access to the `account.move` and `account.move.line` models. Because we're actually sorting lines after the creating, it requires `read` access to sort, and `write` access to modify their sequence. This is problematic when interracting with other modules like `invoice_mode_at_shipping` where stock users are the ones to create invoices. This commit adds a few `sudo()` in the code, in order to avoid granting `read` and `write` access to users that shouldn't be allowed to read and write invoices.

…nvoice_with_currency

Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode_at_shipping Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode_at_shipping/es/

…king

Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode_at_shipping Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode_at_shipping/it/

…cking' instead of related

…o 'shipping' instead of 'picking'

…ne_invoice_per_shipping' fill in / Use draft invoices.

…ng' option on res_partner view

…g to commercial_fields

…ing_validation function and add option auto validate invoice on partner

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode_at_shipping Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode_at_shipping/

Currently translated at 58.3% (7 of 12 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode_at_shipping Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode_at_shipping/es/

Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode_at_shipping Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode_at_shipping/it/

Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode_at_shipping Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode_at_shipping/fr/

chaule97 force-pushed the 17.0-mig-partner_invoicing_mode_at_shipping branch 4 times, most recently from fe2355e to 72a873b Compare December 31, 2024 08:32

thienvh332 suggested changes Jan 3, 2025

View reviewed changes

thienvh332 reviewed Jan 3, 2025

View reviewed changes

chaule97 force-pushed the 17.0-mig-partner_invoicing_mode_at_shipping branch 5 times, most recently from b1151a7 to 9496059 Compare January 3, 2025 08:34

chaule97 requested a review from thienvh332 January 3, 2025 08:37

thienvh332 reviewed Jan 3, 2025

View reviewed changes

chaule97 force-pushed the 17.0-mig-partner_invoicing_mode_at_shipping branch from 9496059 to de3c6c9 Compare January 3, 2025 08:54

chaule97 requested a review from thienvh332 January 3, 2025 08:58

thienvh332 approved these changes Jan 3, 2025

View reviewed changes

chaule97 force-pushed the 17.0-mig-partner_invoicing_mode_at_shipping branch 2 times, most recently from 150f82d to d148854 Compare January 3, 2025 15:43

mmequignon and others added 12 commits February 4, 2025 09:49

account_invoice_section_sale_order: fix access right tests not running

36d8c17

account_invoice_section_sale_order: fix access right on move line write

3128497

[FIX] account_invoice_section_sale_order check line_ids exists

d3d08a5

[FIX] account_invoice_section_sale_order: fix test-case test_create_i…

a599acb

…nvoice_with_currency

[MIG] rename account_invoice_mode_at_shipping

2f79521

[MIG] partner_invoicing_mode_at_shipping: Migration to 16.0

c00529f

[UPD] Update partner_invoicing_mode_at_shipping.pot

2d9a5ee

[UPD] README.rst

212022a

partner_invoicing_mode_at_shipping 16.0.1.0.1

dc4798e

Added translation using Weblate (Spanish)

1477883

OCA-git-bot and others added 20 commits February 4, 2025 09:50

[UPD] README.rst

51bf4ba

[IMP] partner_invoicing_mode_at_shipping: Add grouping option per pic…

7196388

…king

Added translation using Weblate (Italian)

645f53d

[IMP] partner_invoicing_mode_at_shipping: Compute 'one_invoice_per_pi…

e38f012

…cking' instead of related

[IMP] partner_invoicing_mode_at_shipping: Refactor tests and change t…

a7ce080

…o 'shipping' instead of 'picking'

[IMP] partner_invoicing_mode_at_shipping: Add migration script for 'o…

6f2260f

…ne_invoice_per_shipping' fill in / Use draft invoices.

[IMP] partner_invoicing_mode_at_shipping: Add 'one_invoice_per_shippi…

382813f

…ng' option on res_partner view

[IMP] partner_invoicing_mode_at_shipping: Remove unused function

ac358ff

[FIX] partner_invoicing_mode_at_shipping: Add one_invoice_per_shippin…

f5fa1b3

…g to commercial_fields

[IMP] partner_invoicing_mode_at_shipping: Extract _invoicing_at_shipp…

a8fe4e2

…ing_validation function and add option auto validate invoice on partner

[UPD] Update partner_invoicing_mode_at_shipping.pot

73eab0a

[BOT] post-merge updates

57048ea

Added translation using Weblate (French)

ab93046

[IMP] partner_invoicing_mode_at_shipping: pre-commit auto fixes

d3abea9

[MIG] partner_invoicing_mode_at_shipping: Migration to 17.0

3f12bd5

chaule97 force-pushed the 17.0-mig-partner_invoicing_mode_at_shipping branch from d148854 to 3f12bd5 Compare February 4, 2025 02:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] partner_invoicing_mode_at_shipping: Migration to 17.0 #4

[17.0][MIG] partner_invoicing_mode_at_shipping: Migration to 17.0 #4

chaule97 commented Dec 31, 2024

thienvh332 Jan 3, 2025

thienvh332 Jan 3, 2025

chaule97 Jan 3, 2025

thienvh332 Jan 3, 2025

thienvh332 Jan 3, 2025

thienvh332 Jan 3, 2025

thienvh332 Jan 3, 2025

thienvh332 Jan 3, 2025

thienvh332 Jan 3, 2025

chaule97 Jan 3, 2025 •

edited

Loading

thienvh332 Jan 3, 2025

thienvh332 Jan 3, 2025

thienvh332 left a comment

	"depends": ["account", "partner_invoicing_mode", "queue_job", "sale_stock"],
	"depends": ["account", "partner_invoicing_mode", "queue_job", "stock"],

		# generated from manifests external_dependencies
		openupgradelib

		@@ -0,0 +1,4 @@
		from . import res_partner
		from . import stock_move

		@@ -0,0 +1,3 @@
		The development of this module has been financially supported by:

		- Camptocamp

[17.0][MIG] partner_invoicing_mode_at_shipping: Migration to 17.0 #4

Are you sure you want to change the base?

[17.0][MIG] partner_invoicing_mode_at_shipping: Migration to 17.0 #4

Conversation

chaule97 commented Dec 31, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chaule97 Jan 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thienvh332 left a comment

Choose a reason for hiding this comment

chaule97 Jan 3, 2025 •

edited

Loading