build: use 1 codegen-units for release builds #4464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
changed the title
According to my measurements this reduced libdeltachat.so size by 3.3 MB, from 25.17 to 21.84 MB.
link2xt
force-pushed
the
link2xt/codegen-units-1
branch
from
f8e20c6 to
b9a5ab5
Compare
|
I have looked at the git history, we have never set it before except in |
|
I am not sure about these measurements, they are indeed flaky. It is better to test the final APK size. |
|
interesting, thanks! i am now building a test apk with this pr |
r10s
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
nice! thanks a lot for that!
i did some measurements with apk at #4463 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my measurements
this reduced libdeltachat.so size
by 3.3 MB, from 25.17 to 21.84 MB.