Separate IMAP and SMTP configuration #1835
Conversation
Hocuri
changed the title
|
Ping @link2xt maybe you can have a look at it, whether this was the way you intended it. You can also push at this pr, I will be careful with force pushing. |
|
The ci is failing, looks like this bug: rust-lang/rust#64496 |
Hocuri
changed the title
link2xt
changed the title
link2xt
changed the title
| } | ||
| param.send_port = match param.send_security { | ||
| Socket::Automatic => 0, | ||
| Socket::STARTTLS | Socket::Plain => 587, |
There was a problem hiding this comment.
I have changed heuristic to use port 587 instead of port 25 for plain.
Port 25 is for MTA-MTA transmission, it shoud not be used by Delta Chat at all.
link2xt
force-pushed
the
nicer-configure
branch
from
654c038 to
ebb4269
Compare
ci in #1831 is failing because of the same bug - in fact, i came to this issue when searching for the error string in duckduckgo :) |
link2xt
force-pushed
the
nicer-configure
branch
3 times, most recently
from
25db574 to
15eca6e
Compare
link2xt
changed the title
| pub type SmtpServers = Vec<ServerParams>; | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct LoginParamNew { |
There was a problem hiding this comment.
This name is unclear. Could it be named AutoconfigParam or something like this?
As I understand it, loginparam_old_to_new converts user-provided settings into the input for automatic configuration algorithm, and loginparam_new_to_old is a very simple autoconfiguration algorithm that converts results obtained from autoconfig XML or provider database into LoginParam with the first IMAP and SMTP server.
"Old" LoginParam is not going anywhere until automatic reconfiguration is implemented, and it is not a short-term goal. It is what is saved in the database under configured_ settings.
Also this LoginParamNew, besides renaming, could be moved into configure module.
There was a problem hiding this comment.
Sure, I had not really thought about naming before and such things before.
There was a problem hiding this comment.
As for loginparam_old_to_new and the other way round, the thought was that I could implement point 5 only partly first and then already test it using these conversion methods. And that they might come handy later under a different name.
So, feel free to rename and change these things, I never planned to merge these functions as they currently are.
link2xt
force-pushed
the
nicer-configure
branch
3 times, most recently
from
6032a5c to
88a4a0a
Compare
link2xt
force-pushed
the
nicer-configure
branch
from
b0842c9 to
8e70534
Compare
|
maybe we should do a bugfix-release core45 before merging that finally in, also as this requires some additional work in the uis. |
link2xt
force-pushed
the
nicer-configure
branch
3 times, most recently
from
a60b2f8 to
5dcbb88
Compare
Co-Authored-By: link2xt <[email protected]> Co-Authored-By: bjoern <[email protected]>
From #1832 (for 2 it was necessary to also do 5, and I am not done with 2 yet, either)
(by @link2xt)
Fixes #646
Also fixes point (4), previously
AcceptInvalidCertificatesinstead ofAutomaticsettings were applied for autoconfigured (with either XML or provider DB) servers, sostrict_tlswas not used.