Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve GetObjectSliceDiff performances #41

Merged
merged 1 commit into from
May 5, 2020
Merged

improve GetObjectSliceDiff performances #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,30 +56,26 @@ func (object Object) HasExtension(extension string) bool {
// GetObjectSliceDiff takes two objects slices and returns an ObjectSliceDiff
func GetObjectSliceDiff(os1 []Object, os2 []Object, timestampTolerance time.Duration) ObjectSliceDiff {
var diff ObjectSliceDiff
om1 := make(map[string]Object)
om2 := make(map[string]Object)
for _, o1 := range os1 {
found := false
for _, o2 := range os2 {
if o1.Path == o2.Path {
found = true
if o2.LastModified.Sub(o1.LastModified) > timestampTolerance {
diff.Updated = append(diff.Updated, o2)
}
break
om1[o1.Path] = o1
}
for _, o2 := range os2 {
om2[o2.Path] = o2
}
for _, o1 := range os1 {
if o2, found := om2[o1.Path]; found {
if o2.LastModified.Sub(o1.LastModified) > timestampTolerance {
diff.Updated = append(diff.Updated, o2)
}
}
if !found {
} else {
diff.Removed = append(diff.Removed, o1)
}
}

for _, o2 := range os2 {
found := false
for _, o1 := range os1 {
if o2.Path == o1.Path {
found = true
break
}
}
if !found {
if _, found := om1[o2.Path]; !found {
diff.Added = append(diff.Added, o2)
}
}
Expand Down