all: deprecate NOS for no license in their codebase (#747)

Background tracks here: github.com/helm/chartmuseum/issues/646 , we make a decision to deprecate NOS backend, and we hope we can revert this commit someday. Signed-off-by: scnace <[email protected]> Signed-off-by: scnace <[email protected]>
chartmuseum · Jan 9, 2023 · 469842c · 469842c
1 parent f8566d7
commit 469842c
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 318 deletions.
diff --git a/go.mod b/go.mod
@@ -5,7 +5,6 @@ go 1.17
 require (
 	cloud.google.com/go/storage v1.22.1
 	github.com/Azure/azure-sdk-for-go v65.0.0+incompatible
-	github.com/NetEase-Object-Storage/nos-golang-sdk v0.0.0-20191125093154-335c2b73bf6b
 	github.com/aliyun/aliyun-oss-go-sdk v2.2.4+incompatible
 	github.com/aws/aws-sdk-go v1.44.27
 	github.com/baidubce/bce-sdk-go v0.9.123

diff --git a/go.sum b/go.sum
@@ -79,8 +79,6 @@ github.com/Azure/go-autorest/tracing v0.6.0 h1:TYi4+3m5t6K48TGI9AUdb+IzbnSxvnvUM
 github.com/Azure/go-autorest/tracing v0.6.0/go.mod h1:+vhtPC754Xsa23ID7GlGsrdKBpUA79WCAKPPZVC2DeU=
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
 github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
-github.com/NetEase-Object-Storage/nos-golang-sdk v0.0.0-20191125093154-335c2b73bf6b h1:jZIv0SILYL0wRLzAB8Ha19VDm7JnYn8t9NYbz2s2AVc=
-github.com/NetEase-Object-Storage/nos-golang-sdk v0.0.0-20191125093154-335c2b73bf6b/go.mod h1:0N5CbwYI/8V1T6YOEwkgMvLmiGDNn661vLutBZQrC2c=
 github.com/OneOfOne/xxhash v1.2.2/go.mod h1:HSdplMjZKSmBqAxg5vPj2TmRDmfkzw+cTzAElWljhcU=
 github.com/QcloudApi/qcloud_sign_golang v0.0.0-20141224014652-e4130a326409/go.mod h1:1pk82RBxDY/JZnPQrtqHlUFfCctgdorsd9M06fMynOM=
 github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=

diff --git a/netease.go b/netease.go
diff --git a/netease_test.go b/netease_test.go
diff --git a/storage_test.go b/storage_test.go
@@ -38,7 +38,7 @@ func (suite *StorageTestSuite) setupStorageBackends() {
 	suite.StorageBackends["LocalFilesystem"] = Backend(NewLocalFilesystemBackend(suite.TempDirectory))
 
 	// create empty dir in local storage to make sure it doesnt end up in ListObjects
-	err := os.MkdirAll(fmt.Sprintf("%s/%s", suite.TempDirectory, "ignoreme"), 0777)
+	err := os.MkdirAll(fmt.Sprintf("%s/%s", suite.TempDirectory, "ignoreme"), 0o777)
 	suite.Nil(err, "No error creating ignored dir in local storage")
 
 	if os.Getenv("TEST_CLOUD_STORAGE") == "1" {
@@ -58,8 +58,6 @@ func (suite *StorageTestSuite) setupStorageBackends() {
 		bosEndpoint := os.Getenv("TEST_STORAGE_BAIDU_ENDPOINT")
 		cosBucket := os.Getenv("TEST_STORAGE_TENCENT_BUCKET")
 		cosEndpoint := os.Getenv("TEST_STORAGE_TENCENT_ENDPOINT")
-		nosBucket := os.Getenv("TEST_STORAGE_NETEASE_BUCKET")
-		nosEndpoint := os.Getenv("TEST_STORAGE_NETEASE_ENDPOINT")
 		if s3Bucket != "" && s3Region != "" {
 			suite.StorageBackends["AmazonS3"] = Backend(NewAmazonS3Backend(s3Bucket, prefix, s3Region, "", ""))
 		}
@@ -84,9 +82,6 @@ func (suite *StorageTestSuite) setupStorageBackends() {
 		if cosBucket != "" {
 			suite.StorageBackends["TencentCloudCOS"] = Backend(NewTencentCloudCOSBackend(cosBucket, prefix, cosEndpoint))
 		}
-		if nosBucket != "" {
-			suite.StorageBackends["NeteaseCloudNOS"] = Backend(NewNeteaseNOSBackend(nosBucket, prefix, nosEndpoint))
-		}
 	}
 }
 
@@ -238,7 +233,6 @@ func (suite *StorageTestSuite) TestGetObjectSliceDiff() {
 	suite.Empty(diff.Removed, "removed slice empty")
 	suite.Equal(diff.Added, []Object{os2[1]}, "added slice empty")
 	suite.Empty(diff.Updated, "updated slice empty")
-
 }
 
 func TestStorageTestSuite(t *testing.T) {