Fix deprecation warnings in PHP 8.4 for dynamic property creation #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @twoleds, thanks a lot for the contribution. There is something wrong with checks, once we'll figure that out we'll be able to merge this. |
|
Hello @twoleds. could you please update your branch with the latest code in the main branch, so we unlock github actions to check if everything is ok with that? |
twoleds
force-pushed
the
fix-dynamic-properties
branch
from
58dedc2 to
1fd409f
Compare
swember
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if this is a good fix; maybe a better approach would be to create an array for non-existent properties and define magic methods for set/isset.