-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sc-57428): Support Opportunities API #124
feat(sc-57428): Support Opportunities API #124
Conversation
This pull request has been linked to Shortcut Story #57428: Support Opportunities resource - PHP client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I left a question
"type": "recurring", | ||
"forecast_category": "pipeline", | ||
"win_likelihood": 3, | ||
"custom": {"from_campaign": true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think custom type is array in here but this type is object Ah please ignore this comment. I checked the api document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch, but the data should be correct now 😊
I just added a new test for creating the opportunity from customer.
Code Climate has analyzed commit caad9bf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 75.6%. View more on Code Climate. |
closes ticket: https://app.shortcut.com/chartmogul/story/57428/support-opportunities-resource-php-client
API Specs: https://www.notion.so/chartmogul/API-endpoints-for-Opportunities-a92323514bf44f89ad2f97ae30cee7f0#6f09cc7a71bc40e69ef65d8d0342d230
Customers
List Opportunities from a customer
Create an Opportunity from a customer
Opportunities
List Opportunities
Create an Opportunity
Get an Opportunity
Update an Opportunity
Delete an Opportunity