Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build more reactive charms on lpbuilders #1545

Closed
wants to merge 1 commit into from
Closed

Build more reactive charms on lpbuilders #1545

wants to merge 1 commit into from

Conversation

addyess
Copy link
Member

@addyess addyess commented Jul 25, 2024

Adds more charms to be built with lpbuilders by adding a charmcraft.yaml to their repos

kwmonroe
kwmonroe approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but we should hold off on merge until the 3 charmcrafts land.

@addyess addyess closed this Jul 26, 2024
@addyess addyess deleted the KU-1078/reactive-on-lp-builder branch September 4, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwmonroe kwmonroe kwmonroe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @kwmonroe