Implement configuration of control plane services #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cynerva
force-pushed
the
gkk/api
branch
3 times, most recently
from
ceb25ec
to
c202fb3
Compare
|
Ready for review. I cleaned up the TODOs that I could, but the remaining ones mostly can't be addressed without tackling the whole cloud integration story. I don't think we're ready for that just yet. |
kwmonroe
approved these changes
Aug 24, 2023
| args.update(base_args) | ||
| args.update(extra_args) | ||
|
|
||
| # TODO: CIS arg handling??? |
There was a problem hiding this comment.
we'll likely drop this going forward as we're cis compliant ootb and moving to trivy for runtime scanning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.