LP#2064305 - Provide method to update kubeconfigs of known formats #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
force-pushed
the
bug/lp2064305/support-updating-kubeconfig
branch
2 times, most recently
from
1406efc
to
5fb890c
Compare
addyess
changed the title
addyess
commented
Jun 18, 2024
charms/kubernetes_snaps.py
Outdated
Comment on lines
489
to
492
| assert content["clusters"][0]["name"] == JUJU_CLUSTER | ||
| assert content["contexts"][0]["name"] == JUJU_CLUSTER | ||
| assert content["contexts"][0]["context"]["cluster"] == JUJU_CLUSTER |
There was a problem hiding this comment.
We could do this another way without the assert. I'm open to ideas
addyess
force-pushed
the
bug/lp2064305/support-updating-kubeconfig
branch
from
5fb890c
to
04eab04
Compare
mateoflorido
approved these changes
Jun 20, 2024
addyess
added a commit
that referenced
this pull request
Jun 20, 2024
addyess
added a commit
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP#2064305
Overview
It's not enough to just create a kubeconfig, there are occasions we need to update an existing one. Easy enough to just implement create with the update method
Details
Provide a method of updating an existing kubeconfig file in the event some data like user, token, ca or server changes