[Cherry] Supply option to set the authz-webhook-config-file (#18) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Supply option to set the authz-webhook-config-file * prevent authorization-webhook-config-file if Webhook not enabled
mateoflorido
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick to release 1.29 from #18
Overview
In order to allow keystone authorization (or any external authorizing agent), the api-server must allow the configuration of the
authorization-webhook-config-file.Details
These changes allow for the caller to provide independent args for both
authorization-webhook-config-fileandauthorization_modes, but the two will be reconciled against one another:the
authorization_modescan containWebhookiffauthorization-webhook-config-fileis a valid non-empty file.the
authorization-webhook-config-filewill be ignored ifWebhookisn't present inauthorization_modesThis is done to protect the api-server from not starting up in invalid configuration situations.